Skip to content

Close view when variant analyis is deleted from query history#1680

Merged
koesie10 merged 1 commit intomainfrom
koesie10/close-webview-on-history-item-delete
Oct 31, 2022
Merged

Close view when variant analyis is deleted from query history#1680
koesie10 merged 1 commit intomainfrom
koesie10/close-webview-on-history-item-delete

Conversation

@koesie10
Copy link
Copy Markdown
Member

This will close the variant analysis view when the corresponding variant analysis history item is deleted from the query history. This required some extra code to handle dispose being called on the view to ensure this actually disposes the panel, but we can now call dispose() on the view to close it.

Checklist

  • CHANGELOG.md has been updated to incorporate all user visible changes made by this pull request.
  • Issues have been created for any UI or other user-facing changes made by this pull request.
  • [Maintainers only] If this pull request makes user-facing changes that require documentation changes, open a corresponding docs pull request in the github/codeql repo and add the ready-for-doc-review label there.

This will close the variant analysis view when the corresponding variant
analysis history item is deleted from the query history. This required
some extra code to handle `dispose` being called on the view to ensure
this actually disposes the panel, but we can now call `dispose()` on the
view to close it.
@koesie10 koesie10 requested review from a team as code owners October 31, 2022 10:21
@koesie10 koesie10 merged commit 1cce7ae into main Oct 31, 2022
@koesie10 koesie10 deleted the koesie10/close-webview-on-history-item-delete branch October 31, 2022 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants